SpringBoot SearchStrategy argument of MethodValidationExcludeFilter byAnnotation(Class, SearchStrategy) is not used

From @chanhyeong on Gitter:

I have a question about the static method byAnnotation(Class<? extends Annotation> annotationType, SearchStrategy searchStrategy) in MethodValidationExcludeFilter. It has a searchStrategy argument that doesn't be used (has a fixed value SearchStrategy.SUPERCLASS)

This looks like a bug to me. The search strategy argument should be passed into the call to MergedAnnotations.from.

Comment From: chanhyeong

@wilkinsona I've checked that MethodValidationExcludeFilterTests returns success, regardless of whether it is passed or not. Would you mind If I modified this code?

Comment From: wilkinsona

Thanks for the offer, @chanhyeong. The tests passing even when the code is changed is actually a bad thing. It tells me that the tests need to be changed too.

If you’d like to work on an issue where we provide some guidance, please watch for one labelled as ideal for contribution or, if you haven’t contributed before, first-timers only.

Comment From: pruidong

@wilkinsona I think I can submit a fix for this.

Comment From: wilkinsona

Thanks for the offer. I have a fix and a test ready to push once I’m back in the office.

Comment From: pruidong

Thanks for the offer. I have a fix and a test ready to push once I’m back in the office.

Ok, hope to have the opportunity to provide PR to Spring Boot in the future.