Rename the SomeProperties class so that it is consistent with other examples given within the Type-safe Configuration Properties. This ensures that readers can intuitively draw the conclusion tha the MyProperties class is annotated with ConfigurationProperties.
Fixes gh-32638
Comment From: snicoll
Thanks for the PR @eurythmia. We can't merge this in 2.5.x though I am afraid as it is out of OSS support. When looking into this, there are further confusing reference to SomeProperties in the doc itself that should be revisited.
There's no need for you to do anything btw, we'll review this as part of merging.
Comment From: Ch4ni
Thanks for taking a look and handling the admin work! I did my best to follow the wiki, but never thought to check what's currently in supported status.
I chose 2.5.x because it was the earliest branch exhibiting the specific issue I saw, forward merging or cherry-picking to 2.6.x and 2.7.x should be relatively straightforward (2.7.x is where I originally noticed this).
I can take a look at the section to update the *.adoc, and the kotlin example with this change if you'd like (perhaps targeting 2.6.x).
I also noticed a typo in my commit message after pushing and was reticent to rewrite the history on a PR ('s/tha /that /') with a commit amendment, so that should definitely be a candidate for commit polish :-)
Comment From: snicoll
I can take a look at the section to update the *.adoc, and the kotlin example with this change if you'd like (perhaps targeting 2.6.x)
Thanks but the Kotlin source is available as of 2.7.x so that's something we need to do as part of merging anyway. I'll take care of it. You can push force on your existing branch if you want to fix the typo.
Comment From: snicoll
@eurythmia thank you for making your first contribution to Spring Boot.