adds the functionality according to #33474 - removes additional checks for netty/jetty/Apache HttpClient dependencies
Comment From: pivotal-cla
@anugrahsinghal Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-cla
@anugrahsinghal Thank you for signing the Contributor License Agreement!
Comment From: anugrahsinghal
At least in org.springframework.boot.test.web.reactive.server.WebTestClientContextCustomizerFactory we check for the presence of netty / jetty / apache httpclient. This check can be removed, and maybe such checks are somewhere else in the codebase.
@mhalbritter I have used this sourcegraph query to find the presence of similar dependencies in other places in the codebase, and could not find one that would need removal.
this sourcegraph query essentially checks for the presence of
"reactor.netty.http.client.HttpClient"
"org.eclipse.jetty.client.HttpClient"
"org.apache.hc.client5.http.impl.async.CloseableHttpAsyncClient"
"org.apache.hc.core5.reactive.ReactiveDataConsumer"
in spring-projects org
Comment From: anugrahsinghal
@mhalbritter a little bit unsure of how to handle this test
since we removed the conditions that checked for the presence of netty/jetty/apache client
the WebTestClientContextCustomizerFactory is always non-null
even after the @ClassPathExclusions({ "reactor-netty*.jar", "jetty-client*.jar" })
Do you have any suggestions on how to modify this test case?
Comment From: scottfrederick
@anugrahsinghal I think the WebTestClientContextCustomizerWithoutSupportedHttpClientTests can be removed, since there is no longer a case where no client is availble.
Comment From: anugrahsinghal
hey @scottfrederick
I have removed the WebTestClientContextCustomizerWithoutSupportedHttpClientTests test.
Comment From: mhalbritter
Thanks and congratulations to your first contribution to Spring Boot!