Comment From: pivotal-cla
@plebcity Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-cla
@plebcity Thank you for signing the Contributor License Agreement!
Comment From: wilkinsona
Thanks for the proposal, @plebcity. Unfortunately, I don't think this is the right way to implement this. The most important thing is that the the behaviour needs to be configurable and the current behaviour must remain the default. As indicated by the pending design work label on 28978, we don't know exactly how this will look. I suspect we'll add something that's the equivalent of --creation-time in the pack CLI but we won't know the answer or be able to proceed with the enhancement until we've done the required design work. Thank you for your patience in the meantime.
Comment From: quaff
Thanks for the proposal, @plebcity. Unfortunately, I don't think this is the right way to implement this. The most important thing is that the the behaviour needs to be configurable and the current behaviour must remain the default. As indicated by the pending design work label on 28978, we don't know exactly how this will look. I suspect we'll add something that's the equivalent of
--creation-timein the pack CLI but we won't know the answer or be able to proceed with the enhancement until we've done the required design work. Thank you for your patience in the meantime.
I don't think current behaviour must remain the default, nobody want creation time to be WINDOWS EPOCH.
Comment From: vpavic
nobody want creation time to be WINDOWS EPOCH
This couldn't be any further from the truth. Many of us highly value reproducibility and prefer it as a default wherever possible.
I'm saying this as someone who doesn't use Spring Boot's support for building Docker images, but rather perfers Jib - a build plugin that does the same thing by default.
Comment From: quaff
nobody want creation time to be WINDOWS EPOCH
This couldn't be any further from the truth. Many of us highly value reproducibility and prefer it as a default wherever possible.
I'm saying this as someone who doesn't use Spring Boot's support for building Docker images, but rather perfers Jib - a build plugin that does the same thing by default.
Jib use UNIX rather than WINDOWS EPOCH, I'm curious why 1980 not 1970 at first time.