SpringBoot SSL configuration overwrites other WebClient customization

Issue: Whenever you are configuring TLS on a webclient, any other custom configuration of HttpClient is lost and not applied to the final instance.

Example:

  @Bean
  public WebClient webClient(
      ...
    return WebClient.builder().apply(clientSsl.fromBundle(sslBundle)).build();
  }

  @Bean
  public ReactorNettyHttpClientMapper httpClient() {
   // This is not applied to the WebClient instance generated by the builder on webclient()
    return client ->
        client.compress(true)

Check the code being changed, where we can see that mapper is being reassigned to only consider configurations from SslConfigurer. It should be just added to the map stream, so everything is applied

Comment From: pivotal-cla

@fcappi Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Comment From: pivotal-cla

@fcappi Thank you for signing the Contributor License Agreement!

Comment From: scottfrederick

@fcappi Thanks for the suggestion. Can you describe the problem that this change is intended to solve? Ideally we'd have tests to verify that the existing behavior is incorrect, and change the tests to match the new behavior.

Comment From: fcappi

Hey @scottfrederick , sorry for that. I created the PR before it was ready. Details added to the PR description. Tests are covering the expected behaviour.

Comment From: philwebb

Thanks very much for contributing @fcappi!