This pull request addresses the issue #35791, where it was required to replace verifyComplete() with expectComplete().verify(Duration) in test cases across multiple files.
Changes made:
- Replaced
verifyComplete()withexpectComplete().verify(Duration.ofSeconds(5))in all the necessary places. The decision to useDuration.ofSeconds(5)was influenced by its existing usage in another part of the project, ensuring consistency across the codebase. - Added
import java.time.Duration;where it was not already imported.
I have successfully made changes to 23 files and built the project without any errors. All the tests ran successfully after the changes.
Comment From: pivotal-cla
@ThomazPassarelli Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: philwebb
When we merge this we should also consider this comment from the original issue:
We should also consider introducing an ArchUnit rule to prevent usage of verifyComplete() from being reintroduced.
Comment From: wilkinsona
I've got one locally.
We should also remove any calls to StepVerifier.setDefaultTimeout as they're unnecessary when using expectedComplete().verify(Duration) everywhere.
Comment From: wilkinsona
@ThomazPassarelli can you please sign the CLA when you have a moment?
Comment From: pivotal-cla
@ThomazPassarelli Thank you for signing the Contributor License Agreement!
Comment From: wilkinsona
Thanks very much, @ThomazPassarelli.