Changed a little bit of code in ConfigDataLocationBindHandler.onSuccess method. I thought there's no reason to separate Stream and for logic, and that this way would be better to read.
Comment From: pivotal-cla
@elevne Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-cla
@elevne Thank you for signing the Contributor License Agreement!
Comment From: snicoll
Thanks for the PR @elevne but I believe the code is fine as it is and we prefer to do such stylistic code change ourselves.
Comment From: snicoll
@wilkinsona made me aware of the use of Stream in the same class and that this part of the code is a little inconsistent. That's different from the stylistic change I was mentioning early so I am reopening this one.
Comment From: mhalbritter
I like the changes. I find the existing code somewhat odd, as it starts out with a stream and then updates the array via a for loop, which mixes two paradigms. The new code is more consistent.
Comment From: elevne
Thank you for all your comments! I checked the whole body of method again, and thought it would be more consistent to change to streamify upper part as well.
Comment From: snicoll
@elevne thanks very much for making your first contribution to Spring Boot.