Fix for bug fix #34834. The code now allows for no cleanup of the "/" path to "". The rest of the test cases stay as is. Added new tests to verify behaviour
Comment From: somayaj
Hi @philwebb @wilkinsona @mbhave any eta on when the pr will be looked at?
Comment From: wilkinsona
@somayaj No ETA I'm afraid. We'll review it as soon as we have time to do so. Thanks for your patience in the meantime.
Comment From: somayaj
Thanks so much
Comment From: wilkinsona
Thanks for the PR, @somayaj. Unfortunately, I don't think we should have accepted your offer of a contribution to fix this one as it's deceptively complicated. The matching behavior needs to differ depending on whether or not a separate management port is in use as the use of a different port affects whether or not the links endpoint is available. If we merged these changes and a separate management port was not being used, permitting access to the links endpoint could accidentally permit access to something else. Sorry for the wasted effort here.
Comment From: somayaj
Thanks for the PR, @somayaj. Unfortunately, I don't think we should have accepted your offer of a contribution to fix this one as it's deceptively complicated. The matching behavior needs to differ depending on whether or not a separate management port is in use as the use of a different port affects whether or not the links endpoint is available. If we merged these changes and a separate management port was not being used, permitting access to the links endpoint could accidentally permit access to something else. Sorry for the wasted effort here.
@wilkinsona sure, sounds good. Thanks for the opportunity.