Comment From: wilkinsona

@ceki this upgrade is causing some compilation failures:

/Users/awilkinson/dev/spring-projects/spring-boot/main/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/logging/logback/RootLogLevelConfigurator.java:32: error: RootLogLevelConfigurator is not abstract and does not override abstract method configure(Context) in Configurator
public class RootLogLevelConfigurator extends ContextAwareBase implements Configurator {
       ^
/Users/awilkinson/dev/spring-projects/spring-boot/main/spring-boot-project/spring-boot/src/main/java/org/springframework/boot/logging/logback/RootLogLevelConfigurator.java:34: error: method does not override or implement a method from a supertype
        @Override
        ^
2 errors

It appears to be combination of https://github.com/qos-ch/logback/commit/bd11e72017941331f2c3ba5101429359aced5a47 and https://github.com/qos-ch/logback/commit/48a7676ef1b6ea7a0d7fea655d3e18deceabcc76. Can you confirm that this breakage is intentional and that we should adapt to the change?

Comment From: ceki

@wilkinsona I presume that the parameter type of the configure method was changed to Context instead of LoggerContext previously. I forgot to revert that in version 1.4.10 when Configurator was moved back to logback-classic.

Before I cut a new release, have you noticed other problems?

Comment From: ceki

@wilkinsona Logback version 1.4.11 reverts changes made to the configure method in the Configurator interface.

Comment From: wilkinsona

Thank you. Context vs LoggerContext was the only problem I noticed.

Comment From: snicoll

Thanks for the quick support @ceki!