Fixes #37123
I assume the documentation at https://github.com/spring-projects/spring-boot/blob/main/spring-boot-project/spring-boot-docs/src/docs/asciidoc/application-properties.adoc?plain=1#L32 is generated automatically.
Comment From: pivotal-cla
@anessi Please sign the Contributor License Agreement!
Click here to manually synchronize the status of this Pull Request.
See the FAQ for frequently asked questions.
Comment From: pivotal-cla
@anessi Thank you for signing the Contributor License Agreement!
Comment From: pivotal-cla
@anessi Thank you for signing the Contributor License Agreement!
Comment From: mhalbritter
Looks good, thank you. The only thing I'm not sure about is the automatic fallback to spring.rabbit.virtual-host. If you got a working setup right now (virtual host for Rabbit, none for Stream), then this will break after the merge, because Stream will now use the same virtual host as Rabbit does.
Comment From: anessi
Thanks for the feedback.
Yes, you're right that this changes the behavior slightly, but I think most people use the default virtual host / for everything. If someone considers separation by virtual host I would expect that they do it for everything, including streams. But that's opinionated or course 😄. After the change they would have to set spring.rabbit.stream.virtual-host to / to revert back to the old values.
Comment From: anessi
fixed the formatting (line length) using ./gradlew format and the tests also work now.
Comment From: mhalbritter
After discussion with the team, the fallback is fine. We should add a note to the release notes how to restore the old behavior.
Comment From: mhalbritter
Thank you very much @anessi !