While reading the code of Spring Boot, I noticed inconsistency in capitalization.

Here are some instances:

  • In most classes and methods, 'MySql' is written as such, but in test methods, it's written as 'Mysql'.
  • In most classes and methods, 'MariaDb' is written as such, but in test methods, it's written as 'Mariadb'.

I hope it leads to more consistent and readable code. Thanks.

Comment From: pivotal-cla

@JinseongHwang Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

Comment From: pivotal-cla

@JinseongHwang Thank you for signing the Contributor License Agreement!

Comment From: wilkinsona

I'm not sure that I'm in favor of this change. I think the capitalisation of the test method names was intended to match the _ separation in the environment variables that are being tested.

Comment From: mhalbritter

I agree with Andy.

Comment From: JinseongHwang

I agree with you. However, I would like to hear the opinions of more members. There are two opinions.

  • Naming convention dependent on environment variable
  • Same naming convention as other classes and methods

I agree with either method. However, I think the inconsistent parts need to be corrected. getUsernameWhenHasMySqlUser -> getUsernameWhenHasMysqlUser

https://github.com/spring-projects/spring-boot/blob/a31395cd15af931a57be7efc1e2c76d4f29a3dce/spring-boot-project/spring-boot-docker-compose/src/test/java/org/springframework/boot/docker/compose/service/connection/mariadb/MariaDbEnvironmentTests.java#L76-L81

Comment From: philwebb

We discussed this today as a team and we'd like to match the _ separation in the environment variables. @JinseongHwang Thanks for pointing out the inconsistencies. Are you interested in updating this PR to fix those?

Comment From: JinseongHwang

Thank you for the discussion in the team! Only inconsistent parts have been corrected. Thank you. 😁

Comment From: scottfrederick

@JinseongHwang Thanks very much for your first contribution to Spring Boot.