This is just an observation and suggestion, but when reviewing the TomcatWebServer class (source), I noticed the method name for "create a blocking non-daemon to stop immediate shutdown" was named startDaemonAwaitThread() (called from here), when, in fact, the Thread that is created is a "non-daemon" Thread as was intended, apparent inside the method, and as is necessary to prevent shutdown of the Tomcat Web Server JVM.
This method would probably be better named as startNonDaemonAwaitThread(), or maybe startTomcatAwaitThread()
Comment From: itsayopapi
@jxblum can I please work on this issue?
Comment From: philwebb
Thanks for the offer @itsayopapi, but I think it will be easier for us to handle this one ourselves rather than merging a pull-request.
Comment From: jxblum
Hi @itsayopapi - That is up to the Boot team and you. I am sure they would welcome help on this rather simple change if the Boot team feels the change is valid.
Thank you for your interest and help.
Cheers!
Comment From: wilkinsona
As Phil has said above, we'd prefer to handle this one ourselves.